From: Jasper St. Pierre Date: Wed, 28 May 2014 19:18:00 +0000 (-0400) Subject: messageTray: Squash together some duplicated code X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~2442 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=f6b5385495ca281f16d19c64aa6423e57857875c;p=gnome-shell.git messageTray: Squash together some duplicated code https://bugzilla.gnome.org/show_bug.cgi?id=731118 --- diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js index 948a5b88c..971c451a9 100644 --- a/js/ui/messageTray.js +++ b/js/ui/messageTray.js @@ -2268,6 +2268,16 @@ const MessageTray = new Lang.Class({ this._grabHelper.addActor(corner.actor); }, + _resetNotificationLeftTimeout: function() { + this._useLongerNotificationLeftTimeout = false; + if (this._notificationLeftTimeoutId) { + Mainloop.source_remove(this._notificationLeftTimeoutId); + this._notificationLeftTimeoutId = 0; + this._notificationLeftMouseX = -1; + this._notificationLeftMouseY = -1; + } + }, + _onNotificationHoverChanged: function() { if (this._notificationWidget.hover == this._notificationHovered) return; @@ -2277,13 +2287,7 @@ const MessageTray = new Lang.Class({ // No dwell inside notifications at the bottom of the screen this._cancelTrayDwell(); - this._useLongerNotificationLeftTimeout = false; - if (this._notificationLeftTimeoutId) { - Mainloop.source_remove(this._notificationLeftTimeoutId); - this._notificationLeftTimeoutId = 0; - this._notificationLeftMouseX = -1; - this._notificationLeftMouseY = -1; - } + this._resetNotificationLeftTimeout(); if (this._showNotificationMouseX >= 0) { let actorAtShowNotificationPosition = @@ -2719,13 +2723,7 @@ const MessageTray = new Lang.Class({ this._notificationUnfocusedId = 0; } - this._useLongerNotificationLeftTimeout = false; - if (this._notificationLeftTimeoutId) { - Mainloop.source_remove(this._notificationLeftTimeoutId); - this._notificationLeftTimeoutId = 0; - this._notificationLeftMouseX = -1; - this._notificationLeftMouseY = -1; - } + this._resetNotificationLeftTimeout(); if (animate) { this._tween(this._notificationWidget, '_notificationState', State.HIDDEN,